GabrielTofvesson/Discord-Cache-Viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix indiscriminate file move and loop edgecase

Browse Source 
Also, GC should very rarely be triggered manually and program exits automatically upon leaving main. If files.Length > 65536, for-loop would move the same files over and over until File.Move throws PathTooLongException, or loop infinitely if no files match criterion.
This commit is contained in:
Gabriel Tofvesson 2022-01-14 04:04:52 +01:00 committed by GitHub
parent f856e72146
commit c103e17b0b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Discord Cache Viewer/Program.cs
View File

@ -23,9 +23,6 @@ namespace Discord_Cache_Viewer
Console.WriteLine("Processed all files, closing in 10 seconds"); Console.WriteLine("Processed all files, closing in 10 seconds");
// Wait a few seconds before closing // Wait a few seconds before closing
await Task.Delay(kill); await Task.Delay(kill);
// Collect the garbage and close
GC.Collect();
Environment.Exit(0);
} }
/// <summary> /// <summary>
@ -39,17 +36,18 @@ namespace Discord_Cache_Viewer
// Constants for more efficient memory management // Constants for more efficient memory management
const string header = "PNG", extension = ".png"; const string header = "PNG", extension = ".png";
const ushort index = 0; const ushort index = 0;
for (ushort i = 0; i < files.Length; i++) for (int i = 0; i < files.Length; i++)
{ {
// Cache the file path // Cache the file path
var filePath = files[i]; var filePath = files[i];
// We only have to read the first line and check if it has the PNG header. // We only have to read the first line and check if it has the PNG header.
// This also saves some processing time, as we don't have to check the entire file for "PNG", and it reduces false positives. // This also saves some processing time, as we don't have to check the entire file for "PNG", and it reduces false positives.
if (File.ReadAllLines(filePath)[index].Contains(header)) if (File.ReadAllLines(filePath)[index].Contains(header)) {
Console.WriteLine($"{filePath} - Added {extension} extension"); Console.WriteLine($"{filePath} - Added {extension} extension");
// "Move" => "Rename", alright then Microsoft. // "Move" => "Rename", alright then Microsoft.
File.Move(filePath, filePath + extension); File.Move(filePath, filePath + extension);
} }
} }
} }
}
} }