From 71406dfe11c0b181985b3c433d041b6a7eef37ec Mon Sep 17 00:00:00 2001
From: Gabriel Tofvesson <gabriel@tofvesson.se>
Date: Wed, 27 Nov 2024 23:39:51 +0100
Subject: [PATCH] Trace itemStack nil countDelta value

---
 logging.lua           | 12 +++++++-----
 storage/itemstack.lua |  4 ++++
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/logging.lua b/logging.lua
index d46d40d..0d77757 100644
--- a/logging.lua
+++ b/logging.lua
@@ -217,18 +217,20 @@ local function _simpleStringify(inValue, builder, ignoreGlobals, skipFunctions,
   end
 end
 
-local function deepStringify(value)
+function Logging.deepStringify(value)
   local collect = {}
   _simpleStringify(cloneNonRecursive(value, {}), collect, false, false)
   return table.concat(collect)
 end
 
 function Logger:_doPrint(level, message, ...)
-  local result = { tostring(LogLevel[level]), deepStringify(message) }
-  for _,v in ipairs({...}) do
-    table.insert(result, deepStringify(v))
+  if LogLevel.isGreaterOrEqual(level, self.level) then
+    local result = { tostring(LogLevel[level]), Logging.deepStringify(message) }
+    for _,v in ipairs({...}) do
+      table.insert(result, Logging.deepStringify(v))
+    end
+    self.output(table.concat(result, " "))
   end
-  self.output(table.concat(result, " "), level)
 end
 
 function Logger:trace(message, ...)
diff --git a/storage/itemstack.lua b/storage/itemstack.lua
index 781a7ef..dc0367a 100644
--- a/storage/itemstack.lua
+++ b/storage/itemstack.lua
@@ -1,5 +1,6 @@
 local Inventory = require("storage.inventory")
 local Sentinel = require("storage.sentinel")
+local Logger = require("logging").getGlobalLogger()
 
 local ItemStack = Sentinel:tag({}, Sentinel.ITEMSTACK)
 ItemStack.__index = ItemStack
@@ -156,6 +157,9 @@ function ItemStack:hasChanged(listObj, thorough)
 end
 
 function ItemStack:_modify(countDelta, stack)
+  if countDelta == nil then
+    Logger:error("countDelta is nil!", stack)
+  end
   local newCount = self:getCount() + countDelta
   if newCount < 0 then
     error("ERROR: New stack count is negative: "..newCount)