From 327410f781bacf32a9cb27e810c7af8607bd45b8 Mon Sep 17 00:00:00 2001
From: Gabriel Tofvesson <contact@w1zzrd.dev>
Date: Sat, 22 Oct 2022 20:45:34 +0200
Subject: [PATCH] Add firebase callable for voting

---
 functions/src/index.ts        |  3 ++-
 functions/src/route/voting.ts | 47 +++++++++++++++++++++++------------
 2 files changed, 33 insertions(+), 17 deletions(-)

diff --git a/functions/src/index.ts b/functions/src/index.ts
index 79c2ac3..5404b94 100644
--- a/functions/src/index.ts
+++ b/functions/src/index.ts
@@ -3,10 +3,11 @@ import {initializeApp} from "firebase-admin/app";
 
 initializeApp();
 
-import votingRoute, {activeVoteState} from "./route/voting";
+import votingRoute, {activeVoteState, callVote} from "./route/voting";
 import adminRoute, {getAllVotesCall} from "./route/admin";
 
 export const vote = functions.https.onRequest(votingRoute);
 export const admin = functions.https.onRequest(adminRoute);
 export const activeVote = activeVoteState;
+export const castVote = callVote;
 export const getAllVotes = getAllVotesCall;
diff --git a/functions/src/route/voting.ts b/functions/src/route/voting.ts
index b421eee..09cc481 100644
--- a/functions/src/route/voting.ts
+++ b/functions/src/route/voting.ts
@@ -12,28 +12,26 @@ import {
 } from "../types/vote";
 import {updateVoteCount} from "../types/state";
 
+type VoteResult = {success: true} | {error: string, code: number};
 
 const app = express();
 
-app.post("/", async (req: Request, res: Response) => {
-  const voteId = req.body.voteId as string | undefined;
-  const voter = req.body.voter as string | undefined;
-  const voteIndex = parseInt((req.body.voteIndex as string | undefined) ?? "");
-
+const vote = async (
+    voteId: string | undefined,
+    voter: string | undefined,
+    voteIndex: number
+): Promise<VoteResult> => {
   if (!voteId) {
-    res.status(400).json({error: "Missing voteId"});
-    return;
+    return {error: "Missing voteId", code: 400};
   }
 
   if (!voter) {
-    res.status(400).json({error: "Missing voter"});
-    return;
+    return {error: "Missing voter", code: 400};
   }
 
   const vote = await getVoteSnapshot(voteId);
   if (!vote.exists) {
-    res.status(404).json({error: "Vote not found"});
-    return;
+    return {error: "Vote not found", code: 404};
   }
 
   if (
@@ -41,21 +39,29 @@ app.post("/", async (req: Request, res: Response) => {
     voteIndex < 0 ||
     voteIndex >= (vote.data()?.options ?? []).length
   ) {
-    res.status(400).json({error: "Invalid vote index"});
-    return;
+    return {error: "Invalid vote index", code: 400};
   }
 
   const entry = await getVoteEntry(vote.ref, voter);
   if (!entry) {
     await makeVoteEntry(vote.ref, voter, voteIndex);
     await updateVoteCount();
-    res.json({success: true});
-    return;
+    return {success: true};
   }
 
   await updateVoteEntry(entry, voteIndex);
   await updateVoteCount();
-  res.json({success: true});
+  return {success: true};
+};
+
+app.post("/", async (req: Request, res: Response) => {
+  const voteId = req.body.voteId as string | undefined;
+  const voter = req.body.voter as string | undefined;
+  const voteIndex = parseInt((req.body.voteIndex as string | undefined) ?? "");
+
+  const result = await vote(voteId, voter, voteIndex);
+  if ("error" in result) res.status(result.code).json({error: result.error});
+  else res.json(result);
 });
 
 app.get("/", async (req: Request, res: Response) => {
@@ -139,4 +145,13 @@ export const activeVoteState = functions.https.onCall(async () => {
   };
 });
 
+export const callVote = functions.https.onCall(async (data) => {
+  const voteId = data.voteId as string | undefined;
+  const voter = data.voter as string | undefined;
+  const voteIndex = parseInt((data.voteIndex as string | undefined) ?? "");
+
+  const result = await vote(voteId, voter, voteIndex);
+  return "error" in result ? {error: result.error} : {success: true};
+});
+
 export default app;